Skip to content

ENH: Add pandas nullable support to read_orc #50503

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jan 5, 2023
Merged

Conversation

phofl
Copy link
Member

@phofl phofl commented Dec 30, 2022

  • closes #xxxx (Replace xxxx with the GitHub issue number)
  • Tests added and passed if fixing a bug or adding a new feature
  • All code checks passed.
  • Added type annotations to new arguments/methods/functions.
  • Added an entry in the latest doc/source/whatsnew/vX.X.X.rst file if fixing a bug or adding a new feature.

@gfyoung gfyoung added Enhancement IO Data IO issues that don't fit into a more specific label labels Jan 3, 2023
import pandas as pd


def _arrow_dtype_mapping(api) -> dict:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might be just worth calling import_option_dependency here since api always need to be a pyarrow module?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah makes sense, changed

@mroeschke mroeschke added this to the 2.0 milestone Jan 5, 2023
@mroeschke mroeschke merged commit 222e37d into pandas-dev:main Jan 5, 2023
@mroeschke
Copy link
Member

Thanks @phofl

@phofl phofl deleted the read_orc branch January 6, 2023 07:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement IO Data IO issues that don't fit into a more specific label
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants