DOC: Remove all versionchanged / versionadded directives < 1.0.0 #50057
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phofl
reviewed
Dec 4, 2022
| @@ -712,11 +712,6 @@ The ufunc is applied to the underlying array in a :class:`Series`. | |||
| ser = pd.Series([1, 2, 3, 4]) | |||
| np.exp(ser) | |||
|
|
|||
| .. versionchanged:: 0.25.0 | |||
|
|
|||
| When multiple :class:`Series` are passed to a ufunc, they are aligned before | |||
There was a problem hiding this comment.
It might make sense to keep the comments, just without the version changed directive. Also for the others
There was a problem hiding this comment.
Got it, so we have to keep the comments, just remove the directives right?
There was a problem hiding this comment.
Yep, also have to remove the tab before the comment. Has to be on the same level as the comments before and after
iofall
commented
Dec 4, 2022
Comment on lines
-4352
to
-4354
| .. versionadded:: 0.25.0 | ||
| Backtick quoting introduced. | ||
|
|
There was a problem hiding this comment.
Removed this one because it did not make sense to keep it.
Comment on lines
-827
to
-829
| .. versionchanged:: 0.25.0 | ||
| changed default value from :const:`False` to :const:`True`. | ||
|
|
There was a problem hiding this comment.
Removed this comment, since the description already covers that default is True.
Comment on lines
-554
to
-556
| .. versionchanged:: 0.23.0 | ||
| Added to DataFrame. | ||
|
|
There was a problem hiding this comment.
Removed this comment because did not make sense to keep it here.
phofl
approved these changes
Dec 5, 2022
|
thx @iofall |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Remove all
versionchanged/versionaddeddirectives for versions <1.0.0Checks