Skip to content

test: Add test for loc assignment changes datetime dtype #50037

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Dec 5, 2022
Merged

test: Add test for loc assignment changes datetime dtype #50037

Changes from 3 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
221de56
test: Add test for loc assignment changes datetime dtype
alonme Dec 3, 2022
597b516
Update test_loc.py
alonme Dec 3, 2022
997f50d
fix pre-commit
alonme Dec 3, 2022
ba9b41d
Remove comment, add test case, move file
alonme Dec 3, 2022
5efe4c7
Simplify params
alonme Dec 4, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 22 additions & 0 deletions pandas/tests/indexing/test_loc.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2971,6 +2971,28 @@ def test_loc_periodindex_3_levels():
assert mi_series.loc[(p_index[0], "A", "B")] == 1.0


@pytest.mark.parametrize("utc", [False, True])
def test_loc_datetime_assignment_dtype_does_not_change(utc):
# GH#49837
df = DataFrame(
{
# Checking with and without UTC as the original bug didn't occur
# for utc=True
"date": to_datetime(
[datetime(2022, 1, 20), datetime(2022, 1, 22)], utc=utc
),
"update": [True, False],
}
)
# We don't expect the dataframe to be changes at all
expected = df.copy(deep=True)

update_df = df[df["update"]]
df.loc[df["update"], ["date"]] = update_df["date"]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you test for df.loc[df["update"], ["date"]] and df.loc[df["update"], "date"]? This takes significantly different code paths.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yup, actually the bug didn't occur in the second one.
will add.

BTW - is this the right place for the test?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good point, better place is probably frame/indexing/test_indexing


tm.assert_frame_equal(df, expected)


class TestLocSeries:
@pytest.mark.parametrize("val,expected", [(2**63 - 1, 3), (2**63, 4)])
def test_loc_uint64(self, val, expected):
Expand Down