-
-
Notifications
You must be signed in to change notification settings - Fork 18.6k
add multi index with categories test #49975
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@@ -14,9 +14,7 @@ | |||
|
|||
|
|||
@pytest.mark.parametrize("case", [0.5, "xxx"]) | |||
@pytest.mark.parametrize( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please avoid changing unrelated lines for style. We use black via precommit to autoformat the code base: https://pandas.pydata.org/pandas-docs/stable/development/contributing_codebase.html#pre-commit
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry about that, ran pre-commit to address
Failing test seems unrelated to this |
@pytest.mark.parametrize( | ||
"b", | ||
[ | ||
pd.Categorical(["a", "b"], categories=["b", "a"]), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is one of these supposed to have ordered=True
like in the original issue? Otherwise both b
params are the same
This pull request is stale because it has been open for thirty days with no activity. Please update and respond to this comment if you're still interested in working on this. |
Thanks for the pull request, but it appears to have gone stale. If interested in continuing, please merge in the main branch, address any review comments and/or failing tests, and we can reopen. |
rebased master and addresses the comment, I dont think the PR sync while it is closed so you cant see the newest commit |
For some reason I cannot re-open this pull request. Mind opening up another one? |
This PR adds test to address the issue in #49337, which have already been fixed on main
Do you want a entry in the changelog since this is not a fix, just a test to ensure we dont run into this again?
- [ ] Added an entry in the latestdoc/source/whatsnew/vX.X.X.rst
file if fixing a bug or adding a new feature.