REF: reverse dispatch in factorize #49966
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| if isinstance(self, ABCIndex): | ||
| # preserve e.g. NumericIndex, preserve MultiIndex | ||
| uniques = self._constructor(uniques) | ||
| else: |
There was a problem hiding this comment.
does this change from elif isinstance(self, ABCSeries) because here self would always be ABCSeries, so it might as well just be else?
Comment on lines
-746
to
-747
| if not isinstance(values, ABCMultiIndex): | ||
| values = extract_array(values, extract_numpy=True) |
There was a problem hiding this comment.
is this no longer necessary because of the early return above
if isinstance(values, (ABCIndex, ABCSeries)):
return values.factorize(sort=sort, use_na_sentinel=use_na_sentinel)
?
|
|
||
| if isinstance(self, ABCIndex): | ||
| # preserve e.g. NumericIndex, preserve MultiIndex | ||
| uniques = self._constructor(uniques) |
There was a problem hiding this comment.
what's the reason to change this from
uniques = ensure_wrapped_if_datetimelike(uniques)
uniques = self._shallow_copy(uniques, name=None)
? Is it just simpler?
MarcoGorelli
approved these changes
Nov 30, 2022
mroeschke
approved these changes
Dec 1, 2022
|
Thanks @jbrockmendel |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.Needed for upcoming removal of DTA/TDA.freq