DEPR: Change numeric_only to False in various groupby ops #49892
Conversation
rhshadrach
added
Groupby
Deprecate
| warn = FutureWarning if func == "std" else None | ||
| msg = "The default value of numeric_only" | ||
| with tm.assert_produces_warning(warn, match=msg): | ||
| result = df.groupby(level=1, axis=1).agg(func) |
There was a problem hiding this comment.
In 1.5.x we are currently warning in a few erroneous cases with axis=1. Is this worth fixing? I think the PR would have to go straight into 1.5.x because of the enforced deprecations.
There was a problem hiding this comment.
I would say if we haven't gotten an issue about this yet I think it's okay not fixing for now
| @@ -572,7 +572,7 @@ Removal of prior version deprecations/changes | |||
| - Changed default of ``numeric_only`` to ``False`` in all DataFrame methods with that argument (:issue:`46096`, :issue:`46906`) | |||
| - Changed default of ``numeric_only`` to ``False`` in :meth:`Series.rank` (:issue:`47561`) | |||
| - Enforced deprecation of silently dropping nuisance columns in groupby and resample operations when ``numeric_only=False`` (:issue:`41475`) | |||
| - Changed default of ``numeric_only`` to ``False`` in :meth:`.DataFrameGroupBy.sum` and :meth:`.DataFrameGroupBy.mean` (:issue:`46072`) | |||
| - Changed default of ``numeric_only`` to ``False`` in various :class:`.DataFrameGroupBy` methods (:issue:`46072`) | |||
There was a problem hiding this comment.
Still some ops enforce numeric_only=False, mostly those that use _op_via_apply. Will be changing this to
The default of ``numeric_only`` is now ``False`` across all :class:`.DataFrameGroupBy` methods
once all ops are done.
|
does this finish off the nuisance column stuff? |
No - we still have some grouby ops (those that go through _op_via_apply) and then resampler / window. |
…rce_numeric_only_groupby_false
…rce_numeric_only_groupby_false � Conflicts: � doc/source/whatsnew/v2.0.0.rst � pandas/tests/resample/test_resample_api.py
| raise TypeError( | ||
| f"{type(self).__name__}.sem called with " | ||
| f"numeric_only={numeric_only} and dtype {self.obj.dtype}" | ||
| ) | ||
| result = self.std(ddof=ddof, numeric_only=numeric_only_bool) | ||
| result = self.std(ddof=ddof, numeric_only=numeric_only) | ||
| self._maybe_warn_numeric_only_depr("sem", result, numeric_only) |
There was a problem hiding this comment.
is self._maybe_warn_numeric_only_depr still needed?
There was a problem hiding this comment.
Maybe not, but I have another branch built on this that removes it (and should be the final PR for nuisance deprecations).
|
small question, otherwise lgtm |
|
Thanks @rhshadrach |
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.