Skip to content

TST: troubleshoot strict=False xfails #49820

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 20 commits into from
Dec 13, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions pandas/tests/base/test_unique.py
Original file line number Diff line number Diff line change
Expand Up @@ -105,9 +105,6 @@ def test_nunique_null(null_obj, index_or_series_obj):


@pytest.mark.single_cpu
@pytest.mark.xfail(
reason="Flaky in the CI. Remove once CI has a single build: GH 44584", strict=False
)
def test_unique_bad_unicode(index_or_series):
# regression test for #34550
uval = "\ud83d" # smiley emoji
Expand Down
13 changes: 0 additions & 13 deletions pandas/tests/computation/test_eval.py
Original file line number Diff line number Diff line change
Expand Up @@ -860,19 +860,6 @@ def test_basic_frame_series_alignment(
def test_basic_series_frame_alignment(
self, request, engine, parser, index_name, r_idx_type, c_idx_type
):
if (
engine == "numexpr"
and parser == "pandas"
and index_name == "index"
and r_idx_type == "i"
and c_idx_type == "s"
):
reason = (
f"Flaky column ordering when engine={engine}, "
f"parser={parser}, index_name={index_name}, "
f"r_idx_type={r_idx_type}, c_idx_type={c_idx_type}"
)
request.node.add_marker(pytest.mark.xfail(reason=reason, strict=False))
df = tm.makeCustomDataframe(
10, 7, data_gen_f=f, r_idx_type=r_idx_type, c_idx_type=c_idx_type
)
Expand Down
1 change: 1 addition & 0 deletions pandas/tests/extension/json/test_json.py
Original file line number Diff line number Diff line change
Expand Up @@ -277,6 +277,7 @@ def test_combine_add(self, data_repeated):
reason="combine for JSONArray not supported - "
"may pass depending on random data",
strict=False,
raises=AssertionError,
)
def test_combine_first(self, data):
super().test_combine_first(data)
Expand Down