Skip to content

STYLE enable pylint: subprocess-run-check #49781

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 19, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion asv_bench/benchmarks/package.py
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ def time_import(self):
# measurement of the import time we actually care about,
# without the subprocess or interpreter overhead
cmd = [sys.executable, "-X", "importtime", "-c", "import pandas as pd"]
p = subprocess.run(cmd, stderr=subprocess.PIPE)
p = subprocess.run(cmd, stderr=subprocess.PIPE, check=True)

line = p.stderr.splitlines()[-1]
field = line.split(b"|")[-2].strip()
Expand Down
1 change: 0 additions & 1 deletion pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -146,7 +146,6 @@ disable = [
"self-assigning-variable",
"self-cls-assignment",
"signature-differs",
"subprocess-run-check",
"super-init-not-called",
"try-except-raise",
"undefined-loop-variable",
Expand Down
1 change: 1 addition & 0 deletions scripts/run_autotyping.py
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@ def main(argv: Sequence[str] | None = None) -> None:
*args.paths,
"--aggressive",
],
check=True,
)
sys.exit(output.returncode)

Expand Down
2 changes: 1 addition & 1 deletion scripts/validate_docstrings.py
Original file line number Diff line number Diff line change
Expand Up @@ -211,7 +211,7 @@ def validate_pep8(self):
file.write(content)
file.flush()
cmd = ["python", "-m", "flake8", "--quiet", "--statistics", file.name]
response = subprocess.run(cmd, capture_output=True, text=True)
response = subprocess.run(cmd, capture_output=True, check=False, text=True)
stdout = response.stdout
stdout = stdout.replace(file.name, "")
messages = stdout.strip("\n")
Expand Down