Skip to content

TST/CLN: pare down the eval test suite #4974

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 25, 2013
Merged

TST/CLN: pare down the eval test suite #4974

merged 1 commit into from
Sep 25, 2013

Conversation

cpcloud
Copy link
Member

@cpcloud cpcloud commented Sep 24, 2013

Current running time of the eval test suite (not including query)

$ nosetests pandas/computation/tests/test_eval.py                                                   1 ↵
......../home/phillip/Documents/code/py/pandas/pandas/core/frame.py:3088: FutureWarning: TimeSeries broadcasting along DataFrame index by default is deprecated. Please use DataFrame.<op> to explicitly broadcast arithmetic operations along the index
  FutureWarning)
.........................................................................................S.......................................................................................................................
----------------------------------------------------------------------
Ran 217 tests in 190.685s

OK (SKIP=1)

New running time 🚤 :

$ nosetests pandas/computation/tests/test_eval.py
......../home/phillip/Documents/code/py/pandas/pandas/core/frame.py:3088: FutureWarning: TimeSeries broadcasting along DataFrame index by default is deprecated. Please use DataFrame.<op> to explicitly broadcast arithmetic operations along the index
  FutureWarning)
.........................................................................................S.......................................................................................................................
----------------------------------------------------------------------
Ran 217 tests in 39.299s

OK (SKIP=1)

@ghost ghost assigned changhiskhan and cpcloud Sep 24, 2013
@jreback
Copy link
Contributor

jreback commented Sep 24, 2013

can u include alignment tests at least on lhs for all index types
or does it make it take much longer?

@cpcloud
Copy link
Member Author

cpcloud commented Sep 24, 2013

let me see

@cpcloud
Copy link
Member Author

cpcloud commented Sep 24, 2013

okay doesn't add that much (about 3s) to do lhs all index types in the alignment tests (sans PeriodIndex)

@cpcloud
Copy link
Member Author

cpcloud commented Sep 24, 2013

also unmarked a few @slow tests so that the basic alignment tests would run across all our builds except the slow which will run the more complicated tests

@jreback
Copy link
Contributor

jreback commented Sep 24, 2013

gr8 I don't think we have the index interactions anywhere else so that's good

@cpcloud
Copy link
Member Author

cpcloud commented Sep 25, 2013

@jreback merge?

@jreback
Copy link
Contributor

jreback commented Sep 25, 2013

yep

cpcloud added a commit that referenced this pull request Sep 25, 2013
TST/CLN: pare down the eval test suite
@cpcloud cpcloud merged commit 211ea71 into pandas-dev:master Sep 25, 2013
@cpcloud cpcloud deleted the eval-test-paredown branch September 25, 2013 01:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants