TYP: type all arguments with int default values #48761
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
twoertwein
commented
Sep 25, 2022
| stacking_id=None, | ||
| *, | ||
| bins, |
There was a problem hiding this comment.
bins cannot be None as len(None) raises.
mroeschke
approved these changes
Sep 26, 2022
|
Thanks @twoertwein
Yeah definitely. Is there an open issue about this in the issue tracker? IMO public API |
That is also my assumption/expectation :) however, I think that some of the |
noatamir
pushed a commit
to noatamir/pandas
that referenced
this pull request
Nov 9, 2022
* TYP: type all arguments with int default values * multiindex * _get_ordinal_range * fix plotting/_matplotlib/hist.py * mark only bins as keyword-only
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This enables the last missing check from autotyping: adding type annotations for int default values.
Some of the
axismight need some more scrutiny whether they allow only ints or also "index" and "columns". Wouldn't mind postponing that when tighteningAxistoLiteral[0, 1, "index", "columns", "rows"].