CLN: MultiIndex.drop_duplicates #48592
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mroeschke
reviewed
Sep 19, 2022
| @@ -332,7 +332,7 @@ def test_multi_drop_duplicates_pos_args_deprecation(): | |||
| idx = MultiIndex.from_arrays([[1, 2, 3, 1], [1, 2, 3, 1]]) | |||
| msg = ( | |||
| "In a future version of pandas all arguments of " | |||
| "MultiIndex.drop_duplicates will be keyword-only" | |||
| "Index.drop_duplicates will be keyword-only" | |||
There was a problem hiding this comment.
Okay given that our next release is 2.0 which we can remove this test entirely (otherwise the previous error message was a little better)
There was a problem hiding this comment.
maybe we can adjust the deprecation decorator to always print the current class name
There was a problem hiding this comment.
That would be a good enhancement/followup. Mind opening an issue about that?
mroeschke
approved these changes
Sep 19, 2022
|
Thanks @twoertwein |
noatamir
pushed a commit
to noatamir/pandas
that referenced
this pull request
Nov 9, 2022
* CLN: MultiIndex.drop_duplicates * adjust test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think there is no reason why
MultiIndexoverwritesdrop_duplicatesfromIndex:MultiIndex.drop_duplicatesdoes not have a doc-stringThere are a few more methods (
set_names,rename) but in those cases, the annotations might actually be different.