-
-
Notifications
You must be signed in to change notification settings - Fork 18.5k
PERF: Add var to masked arrays #48379
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 5 commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
2fd90b9
Add var to masked interface
phofl f7b00ef
Move test and add whatsnew
phofl 825a49b
Add gh ref
phofl 05b3423
Merge remote-tracking branch 'upstream/main' into masked_var
phofl 9d6532c
Merge remote-tracking branch 'upstream/main' into masked_var
phofl 7752e21
Update pandas/core/array_algos/masked_reductions.py
phofl 01bf0cf
Parametrize test
phofl 46abe99
Merge remote-tracking branch 'upstream/main' into masked_var
phofl File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -696,7 +696,7 @@ def test_empty_multi(self, method, unit): | |
expected = Series([1, np.nan], index=["a", "b"]) | ||
tm.assert_series_equal(result, expected) | ||
|
||
@pytest.mark.parametrize("method", ["mean"]) | ||
@pytest.mark.parametrize("method", ["mean", "var"]) | ||
@pytest.mark.parametrize("dtype", ["Float64", "Int64", "boolean"]) | ||
def test_ops_consistency_on_empty_nullable(self, method, dtype): | ||
|
||
|
@@ -787,6 +787,15 @@ def test_mean_masked_overflow(self): | |
assert result_masked - result_numpy == 0 | ||
assert result_masked == 1e17 | ||
|
||
def test_var_masked_array(self): | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Could you parameterize over There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. added |
||
# GH#48379 | ||
ser = Series([1, 2, 3, 4, 5], dtype="Int64") | ||
ser_numpy_dtype = Series([1, 2, 3, 4, 5], dtype="int64") | ||
result = ser.var() | ||
result_numpy_dtype = ser_numpy_dtype.var() | ||
assert result == result_numpy_dtype | ||
assert result == 2.5 | ||
|
||
@pytest.mark.parametrize("dtype", ("m8[ns]", "m8[ns]", "M8[ns]", "M8[ns, UTC]")) | ||
@pytest.mark.parametrize("skipna", [True, False]) | ||
def test_empty_timeseries_reductions_return_nat(self, dtype, skipna): | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.