BUG: masked mean unnecessarily overflowing #48378
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phofl
added
NA - MaskedArrays
|
Ah, nice, this is possible now because we require numpy >= 1.20 (the
Yeah, I am not really sure why historically sum, prod, etc are methods, while mean is only handled inside |
|
Yes, numpy now supports this in every version we need. Ok great, confused me a little bit too |
|
Added as method |
phofl
commented
Sep 6, 2022
pandas/tests/extension/base/dim2.py
Outdated
| @@ -191,7 +192,11 @@ def test_reductions_2d_axis0(self, data, method): | |||
| kwargs["ddof"] = 0 | |||
|
|
|||
| try: | |||
| result = getattr(arr2d, method)(axis=0, **kwargs) | |||
| if method == "mean": | |||
There was a problem hiding this comment.
We have 2 all NA rows in our array that causes numpy to raise a RuntimeWarning with axis=0. Mean raised previously, so dtype was not checked below
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.Do we want to add mean to the Masked Array interface (I would say yes, but want to check anyway)? This would simplify things a bit.
cc @jorisvandenbossche