Skip to content

REGR: fix reset_index (Index.insert) regression with custom Index subclasses #48058

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Aug 22, 2022
Merged

REGR: fix reset_index (Index.insert) regression with custom Index subclasses #48058

merged 3 commits into from
Aug 22, 2022

Conversation

jorisvandenbossche
Copy link
Member

I added a new test file with a minimal custom Index subclass, as I don't know if it can otherwise be tested with out own indexes (and added a new file since I didn't find existing tests for Index subclasses)

@jorisvandenbossche jorisvandenbossche added Regression Functionality that used to work in a prior pandas version Index Related to the Index class or subclasses labels Aug 12, 2022
@jorisvandenbossche jorisvandenbossche added this to the 1.4.4 milestone Aug 12, 2022
@jorisvandenbossche jorisvandenbossche mentioned this pull request Aug 12, 2022
Closed
3 tasks
simonjayhawkins
simonjayhawkins approved these changes Aug 22, 2022
View reviewed changes
Copy link
Member

@simonjayhawkins simonjayhawkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jorisvandenbossche lgtm

@simonjayhawkins simonjayhawkins merged commit 009d0ad into pandas-dev:main Aug 22, 2022
@lumberbot-app

This comment was marked as resolved.

Sign in to view
simonjayhawkins pushed a commit to simonjayhawkins/pandas that referenced this pull request Aug 22, 2022
@jorisvandenbossche @simonjayhawkins
Backport PR pandas-dev#48058: REGR: fix reset_index (Index.insert) re…
2adbd92 
…gression with custom Index subclasses
@simonjayhawkins simonjayhawkins mentioned this pull request Aug 22, 2022
Merged
phofl pushed a commit that referenced this pull request Aug 22, 2022
@simonjayhawkins @jorisvandenbossche
Backport PR #48058 on branch 1.4.x (REGR: fix reset_index (Index.inse…
145a341 
…rt) regression with custom Index subclasses) (#48199)

Backport PR #48058: REGR: fix reset_index (Index.insert) regression with custom Index subclasses

Co-authored-by: Joris Van den Bossche <jorisvandenbossche@gmail.com>
@jorisvandenbossche jorisvandenbossche deleted the regr-index-insert-custom-class branch August 23, 2022 05:07
noatamir pushed a commit to noatamir/pandas that referenced this pull request Nov 9, 2022
@jorisvandenbossche @noatamir
REGR: fix reset_index (Index.insert) regression with custom Index sub…
a6d64df 
…classes (pandas-dev#48058)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simonjayhawkins simonjayhawkins simonjayhawkins approved these changes

Assignees
No one assigned
Labels
Index Related to the Index class or subclasses Regression Functionality that used to work in a prior pandas version
Projects
None yet
Milestone
1.4.4
Development

Successfully merging this pull request may close these issues.

BUG: Reset index regression
2 participants
@jorisvandenbossche @simonjayhawkins