BUG: iloc.setitem raising NotImplementedError for all null slice with one column df #47987
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phofl
added
Indexing
weikhor
reviewed
Aug 6, 2022
Comment on lines
1719
to
+1724
| elif lib.is_integer(indexer[1]) and indexer[1] == 0: | ||
| # reached via setitem_single_block passing the whole indexer | ||
| indexer = indexer[0] | ||
|
|
||
| elif com.is_null_slice(indexer[1]): | ||
| indexer = indexer[0] |
There was a problem hiding this comment.
Small opinion. Is it better if we combine together condition like this?
elif (lib.is_integer(indexer[1]) and indexer[1] == 0) or (com.is_null_slice(indexer[1])):
# reached via setitem_single_block passing the whole indexer
indexer = indexer[0]
There was a problem hiding this comment.
Put it into two because this is easier to read imo
mroeschke
approved these changes
Aug 8, 2022
|
Thanks @phofl |
noatamir
pushed a commit
to noatamir/pandas
that referenced
this pull request
Nov 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.