Skip to content

BUG: pivot_table raising TypeError with ea dtype and dropna True #47972

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 8, 2022

Conversation

phofl
Copy link
Member

@phofl phofl commented Aug 4, 2022

The aggregation function already provides the correct dtype. In case of numpy dtype we are casting to many cases, see #47971

@phofl phofl added NA - MaskedArrays Related to pd.NA and nullable extension arrays Bug Reshaping Concat, Merge/Join, Stack/Unstack, Explode labels Aug 4, 2022
Copy link
Member

@mroeschke mroeschke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Although this was a regression from 1.2.5, with 1.4.4 coming soon I think this is okay just to fix in 1.5

@mroeschke mroeschke added this to the 1.5 milestone Aug 8, 2022
@mroeschke mroeschke merged commit 4556fe2 into pandas-dev:main Aug 8, 2022
@mroeschke
Copy link
Member

Thanks @phofl

@phofl phofl deleted the 47477 branch August 9, 2022 06:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug NA - MaskedArrays Related to pd.NA and nullable extension arrays Reshaping Concat, Merge/Join, Stack/Unstack, Explode
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BUG: TypeError: Int64 when using pd.pivot_table with Int64 values
2 participants