BUG: Fix read_fwf with compressed files. #4784
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`gzip` and `bz2` both now return `bytes` rather than `str` in Python 3, so need to check for bytes and decode as necessary.
ghost
mentioned this pull request
|
@y-p this look okay to you now? |
|
You already have a +1, what more do you want, blood? :) |
jtratner
added a commit
that referenced
this pull request
Sep 9, 2013
BUG: Fix read_fwf with compressed files.
ghost
mentioned this pull request
|
reopened #3963. bad +1 by me |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3963.
gzipandbz2both now returnbytesrather thanstrin Python 3, soneed to check for bytes and decode as necessary.
replacing #4783