Skip to content

BUG: PeriodIndex + TimedeltaArray-with-NaT #47783

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 20, 2022
Merged

BUG: PeriodIndex + TimedeltaArray-with-NaT #47783

merged 3 commits into from
Jul 20, 2022

Conversation

jbrockmendel
Copy link
Member

Implements the same round_ok behavior in astype_overflowsafe that we use in Timestamp/Timedelta _as_reso, i.e. this will lead to more code-sharing in follow-ups.

mroeschke
mroeschke reviewed Jul 19, 2022
View reviewed changes
@mroeschke mroeschke added Timedelta Timedelta data type Period Period data type labels Jul 19, 2022
@mroeschke mroeschke added this to the 1.5 milestone Jul 19, 2022
@mroeschke
Copy link
Member

I think the test_round_sanity 32 bit failures are unrelated, but is it worth xfailing or fixing soon?

@jbrockmendel
Copy link
Member Author

I think the test_round_sanity 32 bit failures are unrelated, but is it worth xfailing or fixing soon?

definitely worth fixing before long

@mroeschke mroeschke merged commit 9f5c8b9 into pandas-dev:main Jul 20, 2022
@jbrockmendel jbrockmendel deleted the ref-check_timedeltalike_freq_compat branch July 20, 2022 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mroeschke mroeschke mroeschke approved these changes

Assignees
No one assigned
Labels
Period Period data type Timedelta Timedelta data type
Projects
None yet
Milestone
1.5
Development

Successfully merging this pull request may close these issues.
2 participants
@jbrockmendel @mroeschke