TST: added test for to_json when called on numbers exceeding the int64 limit #47589
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phofl
reviewed
Jul 3, 2022
pandas/tests/io/json/test_pandas.py
Outdated
| ], | ||
| ) | ||
| @pytest.mark.parametrize("orient", ["split"]) | ||
| def test_json_uint64(self, data, expected, orient): |
There was a problem hiding this comment.
This is only one test right? You don’t have to paeametrize over arguments that take only one value
There was a problem hiding this comment.
oh ok. Should I refactor and resubmit?
phofl
reviewed
Jul 3, 2022
pandas/tests/io/json/test_pandas.py
Outdated
| '{"columns":["col1"],"index":[0,1],' | ||
| '"data":[[13342205958987758245],[12388075603347835679]]}' | ||
| ) | ||
| orient = "split" |
There was a problem hiding this comment.
You don't have to define orient or data as variables, just put them into the functions directly
There was a problem hiding this comment.
Thanks for the feedback! This is my first contribution to open source, so bear with me :)
phofl
approved these changes
Jul 4, 2022
mroeschke
approved these changes
Jul 5, 2022
|
Thanks @johnmantios |
yehoshuadimarsky
pushed a commit
to yehoshuadimarsky/pandas
that referenced
this pull request
Jul 13, 2022
…4 limit (pandas-dev#47589) * TST: added test for to_json when called on numbers that exceed the int64 limit * TST: removed redundant parametrize wrapper * TST: removed redundant variable declarations
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added test for to_json() when called on numbers exceeding the int64 limit.
Tests and linter pass locally.