-
-
Notifications
You must be signed in to change notification settings - Fork 18.5k
DEPS/TST: tzdata is optional, not required #47467
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 8 commits
2939c10
d4642a9
9a75b85
e112474
371e7fb
bfff268
3c94243
7e48282
eba2fb9
6d7c577
19df15c
19438d2
f36bbe6
5917870
093ca1d
64de406
9a973f0
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -47,6 +47,7 @@ dependencies: | |
- scipy | ||
- sqlalchemy | ||
- tabulate | ||
- tzdata>=2022.1 | ||
- xarray | ||
- xlrd | ||
- xlsxwriter | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -47,6 +47,7 @@ dependencies: | |
- scipy | ||
- sqlalchemy | ||
- tabulate | ||
- tzdata>=2022.1 | ||
- xarray | ||
- xlrd | ||
- xlsxwriter | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -48,6 +48,7 @@ dependencies: | |
- scipy | ||
- sqlalchemy | ||
- tabulate | ||
- tzdata>=2022.1 | ||
- xarray | ||
- xlrd | ||
- xlsxwriter | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -3,10 +3,13 @@ from datetime import ( | |
timezone, | ||
) | ||
|
||
from pandas.compat._optional import import_optional_dependency | ||
|
||
try: | ||
# py39+ | ||
import zoneinfo | ||
from zoneinfo import ZoneInfo | ||
import_optional_dependency("tzdata", errors="raise", min_version="2022.1") | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. IIRC we should only check
Also I think |
||
except ImportError: | ||
zoneinfo = None | ||
ZoneInfo = None | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -39,6 +39,7 @@ s3fs | |
scipy | ||
sqlalchemy | ||
tabulate | ||
tzdata>=2022.1 | ||
xarray | ||
xlrd | ||
xlsxwriter | ||
|
Uh oh!
There was an error while loading. Please reload this page.