Skip to content

DOC: added example of valid input dict in dfgroupby.aggregate #47317

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Jun 13, 2022

Conversation

jasonjiajs
Copy link
Contributor

@jasonjiajs jasonjiajs commented Jun 12, 2022

This edit adds an example in dfgroupby.aggregate, for the more complicated case where the input is a "dict of axis labels -> functions, function names or list of such". It also explicitly states that it is possible to use list as a "function" (where the output will be a list of values for each group in the target column, as seen below).

image

@pep8speaks
Copy link

pep8speaks commented Jun 12, 2022

Hello @jasonjiajs! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2022-06-13 22:48:39 UTC

@jasonjiajs
Copy link
Contributor Author

Hi, this is my first attempt at contributing to the documentation. I've made what I think is a very small change, but it failed 2 tests and I'm not sure why. Would appreciate any help on this!

@mroeschke mroeschke added the Docs label Jun 13, 2022
@mroeschke mroeschke added this to the 1.5 milestone Jun 13, 2022
@mroeschke mroeschke merged commit 032c590 into pandas-dev:main Jun 13, 2022
@mroeschke
Copy link
Member

Great, thanks @jasonjiajs

@jasonjiajs jasonjiajs deleted the doc-update-dfgroupbyagg branch June 13, 2022 23:51
yehoshuadimarsky pushed a commit to yehoshuadimarsky/pandas that referenced this pull request Jul 13, 2022
…-dev#47317)

* DOC: added example of valid input dict in dfgroupby.aggregate

* Updated line spacing to pass flake8 test

* Removed trailing whitespace

* retrying tests

* Rerun tests

* added user-defined function to examples

* Update generic.py
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants