CLN: Improve Exceptions in core/common, io/excel and core/format #4721
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
looks fine |
* more changes to bare exceptions * fixup _mut_exclusive to be more expressive * change interpolate_2d and _maybe_upcast_putmask to assertion errors (with pragmas) Potentially need to check whether these are actually unreachable in normal code... * CLN: Add coverage pragmas to already guarded asserts in CSVFormatter * CLN: io/excel Exceptions - small changes (mostly pragmas and asserts)
jtratner
added a commit
that referenced
this pull request
Sep 2, 2013
CLN: Improve Exceptions in core/common, io/excel and core/format
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #3954.
Cleanups to Exceptions in core/common, io/excel, core/format. A few places I added
# pragma: no cover, because it looked like the code was generally unreachable. A few cleanups in tests/test_common and better error message in_mut_exclusive(which needs to be used in Panel.reindex later on).Specific places to look at (you can also grep for
# pragma: no coverin the diff):