PERF: Remove unnecessary asof join functions

[wlach]

Several functions in the join cython are module are basically just calling others, and can probably be removed. This wouldn't
be a big deal inside python, but in this case it cuts down considerably on the amount of generated cython code.

The tests pass for me locally when I do this and there seems to be significant space savings.

[pep8speaks]

Hello @wlach! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2022-05-05 11:37:26 UTC

[jbrockmendel]

significant space savings

cool, how much?

[wlach]

significant space savings

cool, how much?

I think I was seeing about a megabyte on join.pyx, although I think there might be the potential for further gains.

Unfortunately I wasn't running the tests properly so I didn't notice that my PR didn't actually work. 😦 Need to dig in a bit further.

[wlach]

Ok, think I got this working now. It's not as big an improvement as I thought (about 100k or ~4% off of the generated .so for join, not sure why I got it wrong) but I don't think it impacts readability (arguably it helps) so it seems worth doing.

Before

• 2617696 bytes
• nm: 2949 symbols

After

• 2508880 bytes
• nm: 2873 symbols

[wlach]

Ok, I think this is ready for a look!

docstring and typing information is giving an error but I don't see how it could be related to the code changes here (a very similar pull request from last night was passing):

Error: /home/runner/work/pandas/pandas/pandas/core/generic.py:2529:PR03:pandas.DataFrame.to_hdf:Wrong parameters order. Actual: ('path_or_buf', 'key', 'mode', 'complevel', 'complib', 'append', 'format', 'index', 'min_itemsize', 'nan_rep', 'dropna', 'data_columns', 'errors', 'encoding'). Documented: ('path_or_buf', 'key', 'mode', 'complevel', 'complib', 'append', 'format', 'index', 'errors', 'encoding', 'min_itemsize', 'nan_rep', 'dropna', 'data_columns')

[jreback]

Ok, I think this is ready for a look!

docstring and typing information is giving an error but I don't see how it could be related to the code changes here (a very similar pull request from last night was passing):

Error: /home/runner/work/pandas/pandas/pandas/core/generic.py:2529:PR03:pandas.DataFrame.to_hdf:Wrong parameters order. Actual: ('path_or_buf', 'key', 'mode', 'complevel', 'complib', 'append', 'format', 'index', 'min_itemsize', 'nan_rep', 'dropna', 'data_columns', 'errors', 'encoding'). Documented: ('path_or_buf', 'key', 'mode', 'complevel', 'complib', 'append', 'format', 'index', 'errors', 'encoding', 'min_itemsize', 'nan_rep', 'dropna', 'data_columns')

this is unrelated

[jreback]

thanks @wlach