Skip to content

DOC: Fix errors detected by sphinx-lint #46586

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Apr 7, 2022

Conversation

matilda-me
Copy link
Contributor

Found a few issues on the doc with sphinx-lint.

Fixed them.

@MarcoGorelli
Copy link
Member

Copy link
Member

@datapythonista datapythonista left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really nice clean up. I thought we were already validating this in the CI, but since it's not will be great to have it added to precommit as said. But I think this can be in a follow up PR.

Thanks a lot!

@datapythonista datapythonista changed the title Ran sphinx-lint DOC: Fix errors detected by sphinx-lint Apr 1, 2022
@jreback jreback added this to the 1.5 milestone Apr 3, 2022
Copy link
Member

@MarcoGorelli MarcoGorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice, looks good to me pending green

@matilda-me
Copy link
Contributor Author

I don't understand the error :(

@MarcoGorelli
Copy link
Member

looks unrelated, don't worry about it

@matilda-me
Copy link
Contributor Author

Should I merge main to get it fixed (in other words, do I have something to do?)

@MarcoGorelli
Copy link
Member

I re-ran and it passed - all good, thanks!

@MarcoGorelli MarcoGorelli merged commit 7a56966 into pandas-dev:main Apr 7, 2022
@matilda-me matilda-me deleted the sphinx-lint branch April 8, 2022 09:00
yehoshuadimarsky pushed a commit to yehoshuadimarsky/pandas that referenced this pull request Jul 13, 2022
* Avoid mixing tabs and space.

* fix rst issues found by sphinx-lint.

* Make flake8-rst happy.

* FIX: two hyperlinks in rst.

* Marc' suggestion

* Use sphinx-lint tag in pre-commit hook.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants