Bug46381 - Add storage_option parameter to to_excel method in Styler

[eshirvana]

• closes BUG: pandas.io.formats.style.Styler.to_excel doesn't support storage_options as its documented #46381
• Tests added and passed if fixing a bug or adding a new feature
• All code checks passed.
• Added an entry in the latest doc/source/whatsnew/vX.X.X.rst file if fixing a bug or adding a new feature.

[jreback]

this needs some sort of testing (even though its effectivevly passed thru).

see how we do this for read_csv and would need to do the same on specific types of storage backends.

[github-actions]

This pull request is stale because it has been open for thirty days with no activity. Please update and respond to this comment if you're still interested in working on this.

[rhshadrach]

@eshirvana - are you interested in continuing here? I believe this is fairly close, just fixing the docs and a small improvement to the test.

[eshirvana]

@rhshadrach

i would love to , but I'm not sure how to fix the document part . any help is appreciated

[rhshadrach]

@eshirvana - the easiest way I see to implement is in #46491 (comment). I think we should go ahead and do that to get the version added correct.

[rhshadrach]

Thanks @eshirvana - the docstring change looks good. Some CI failures:

_____________________ ERROR at setup of test_styler_to_s3 ______________________
[gw1] linux -- Python 3.8.13 /usr/share/miniconda/envs/test/bin/python
file /home/runner/work/pandas/pandas/pandas/tests/io/excel/test_style.py, line 214
  def test_styler_to_s3(self, s3_resource, s3so):
E       fixture 'self' not found

Offhand it looks related but rerunning the jobs in case something was flakey. If they fail again, can you have a look.

[rhshadrach]

lgtm, cc @jreback

[rhshadrach]

@eshirvana - can you merge main; I think that will fix the CI issues.

[eshirvana]

@rhshadrach
Not sure what's the issue. Would you please take look and let me know what's the issue and If I can fix it.
Thank you

[rhshadrach]

Thanks @eshirvana!

@rhshadrach Not sure what's the issue. Would you please take look and let me know what's the issue and If I can fix it. Thank you

When there are CI failures in a PR, but recent PRs into main are green, it is likely the failure is unrelated and caused by an issue that has since been fixed. By merging in main into the PR as @jreback did, the CI runs again and we can double check this is the case.

We also like to merge main before merging a PR to run the tests again because it could be that there are other changes that have happened since the tests were last run that would identify issues.