-
-
Notifications
You must be signed in to change notification settings - Fork 18.6k
BUG: avoid OOB flow in read_gbq and to_gbq #46312
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
03988f1
BUG: avoid OOB flow in read_gbq and to_gbq
tswast 9c92b7f
Merge remote-tracking branch 'upstream/main' into oob-deprectation
tswast 429954b
move to "other api changes"
tswast 4d14139
Merge remote-tracking branch 'upstream/main' into oob-deprectation
tswast 2886c2d
add versionchanged
tswast File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -29,7 +29,7 @@ def read_gbq( | |
index_col: str | None = None, | ||
col_order: list[str] | None = None, | ||
reauth: bool = False, | ||
auth_local_webserver: bool = False, | ||
auth_local_webserver: bool = True, | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. same as above There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. |
||
dialect: str | None = None, | ||
location: str | None = None, | ||
configuration: dict[str, Any] | None = None, | ||
|
@@ -63,7 +63,7 @@ def read_gbq( | |
reauth : bool, default False | ||
Force Google BigQuery to re-authenticate the user. This is useful | ||
if multiple accounts are used. | ||
auth_local_webserver : bool, default False | ||
auth_local_webserver : bool, default True | ||
tswast marked this conversation as resolved.
Show resolved
Hide resolved
|
||
Use the `local webserver flow`_ instead of the `console flow`_ | ||
when getting user credentials. | ||
|
||
|
@@ -73,6 +73,12 @@ def read_gbq( | |
https://google-auth-oauthlib.readthedocs.io/en/latest/reference/google_auth_oauthlib.flow.html#google_auth_oauthlib.flow.InstalledAppFlow.run_console | ||
|
||
*New in version 0.2.0 of pandas-gbq*. | ||
|
||
.. versionchanged:: 1.5.0 | ||
Default value is changed to ``True``. Google has deprecated the | ||
``auth_local_webserver = False`` `"out of band" (copy-paste) | ||
flow | ||
<https://developers.googleblog.com/2022/02/making-oauth-flows-safer.html?m=1#disallowed-oob>`_. | ||
dialect : str, default 'legacy' | ||
Note: The default value is changing to 'standard' in a future version. | ||
|
||
|
@@ -202,7 +208,7 @@ def to_gbq( | |
chunksize: int | None = None, | ||
reauth: bool = False, | ||
if_exists: str = "fail", | ||
auth_local_webserver: bool = False, | ||
auth_local_webserver: bool = True, | ||
jreback marked this conversation as resolved.
Show resolved
Hide resolved
|
||
table_schema: list[dict[str, str]] | None = None, | ||
location: str | None = None, | ||
progress_bar: bool = True, | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.