DOC: Add "build C extensions" note #46055
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The C extensions must also be created when you bind your local repository for the first time.
rendner
changed the title
rhshadrach
requested changes
Feb 20, 2022
|
|
||
| python setup.py build_ext -j 4 | ||
|
|
||
| You might need to rebuild the C extensions if/when you merge your repo with upstream/main. |
There was a problem hiding this comment.
Suggested change
| You might need to rebuild the C extensions if/when you merge your repo with upstream/main. | |
| You need to rebuild the C extensions anytime the Cython code in ``pandas/core/_libs`` changes. This most frequently occurs when changing or merging branches. |
There was a problem hiding this comment.
Even better would be to separate out this into a new section, something like "Rebuilding the C extensions" and going into a bit more detail as to the why/how/when. But certainly okay to leave it here for this PR.
There was a problem hiding this comment.
- Is
pandas/core/_libsright? Because such a folder does not exist. I think you meanpandas/_libs?
Even better would be to separate out this into a new section, something like "Rebuilding the C extensions"... But certainly okay to leave it here for this PR.
- That's a good idea. I can create a new issue if that is OK for you.
There was a problem hiding this comment.
Yes, an issue would be great.
There was a problem hiding this comment.
Yes, an issue would be great.
I created one.
|
looks ok @rhshadrach merge when ready |
|
Thanks @rendner! |
meeseeksmachine
pushed a commit
to meeseeksmachine/pandas
that referenced
this pull request
Feb 27, 2022
jreback
pushed a commit
that referenced
this pull request
Feb 27, 2022
Co-authored-by: Daniel Schmidt <rendner@users.noreply.github.com>
Closed
1 task
yehoshuadimarsky
pushed a commit
to yehoshuadimarsky/pandas
that referenced
this pull request
Jul 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the missing information that the C extensions must be built when a local pandas repo was bind for the first time.
I also adjusted the docker commands to:
--build-arg gh_username=yournamewas missing)-w /home/pandas, to directly start in the right directory