ENH: Add defaultdict support for dtype in read_csv #46051
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phofl
commented
Feb 18, 2022
| @@ -471,6 +471,9 @@ def _clean_mapping(self, mapping): | |||
| if isinstance(col, int) and col not in self.orig_names: | |||
| col = self.orig_names[col] | |||
| clean[col] = v | |||
| if isinstance(mapping, defaultdict): | |||
There was a problem hiding this comment.
We could also support defaultdicts directly instead of converting here. but this simplifies adding support for converters to and also we do not have to keep defaultdicts in mind every time we casses the dtypes
mroeschke
reviewed
Feb 22, 2022
mroeschke
reviewed
Feb 22, 2022
|
cool can you rebase |
attack68
reviewed
Mar 1, 2022
| dtype["b.1"] = "int64" | ||
| parser = all_parsers | ||
| result = parser.read_csv(StringIO(data), dtype=dtype) | ||
| expected = DataFrame({"a": [1], "b": 2.0, "a.1": [3], "b.2": [4.0], "b.1": [5]}) |
There was a problem hiding this comment.
did you miss the [] on "b", looks different but dont think there is a reason
There was a problem hiding this comment.
Forgot it yes, but does not really make a difference.
Added nevertheless to be more consistent
# Conflicts: # doc/source/whatsnew/v1.5.0.rst
� Conflicts: � doc/source/whatsnew/v1.5.0.rst
|
this looked fine, can you merge master @phofl |
|
Done |
mroeschke
approved these changes
Mar 22, 2022
|
thanks @phofl very nice as always! |
yehoshuadimarsky
pushed a commit
to yehoshuadimarsky/pandas
that referenced
this pull request
Jul 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.