Skip to content

BUG: error in read_excel with some ods files #45598 #46050

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Mar 3, 2022
Merged

BUG: error in read_excel with some ods files #45598 #46050

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
ae5b1c9
BUG: error in read_excel with some ods files #45598
dimitra-karadima Feb 18, 2022
1ffc062
Merge branch 'main' into fix/45598
dimitra-karadima Feb 28, 2022
b309f2c
BUG: use hasattr instead of dir
dimitra-karadima Feb 28, 2022
4751041
DOC: add issue number in new test case
dimitra-karadima Mar 3, 2022
8574f3c
Merge branch 'main' into fix/45598
dimitra-karadima Mar 3, 2022
a706cb3
DOC: remove comment
dimitra-karadima Mar 3, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions doc/source/whatsnew/v1.5.0.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -406,6 +406,7 @@ I/O
- Bug in :func:`read_parquet` when ``engine="pyarrow"`` which caused partial write to disk when column of unsupported datatype was passed (:issue:`44914`)
- Bug in :func:`DataFrame.to_excel` and :class:`ExcelWriter` would raise when writing an empty DataFrame to a ``.ods`` file (:issue:`45793`)
- Bug in Parquet roundtrip for Interval dtype with ``datetime64[ns]`` subtype (:issue:`45881`)
- Bug in :func:`read_excel` when reading a ``.ods`` file with newlines between xml elements(:issue:`45598`)

Period
^^^^^^
Expand Down
8 changes: 6 additions & 2 deletions pandas/io/excel/_odfreader.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,7 +112,11 @@ def get_sheet_data(
table: list[list[Scalar | NaTType]] = []

for sheet_row in sheet_rows:
sheet_cells = [x for x in sheet_row.childNodes if x.qname in cell_names]
sheet_cells = [
x
for x in sheet_row.childNodes
if hasattr(x, "qname") and x.qname in cell_names
]
empty_cells = 0
table_row: list[Scalar | NaTType] = []

Expand Down Expand Up @@ -243,5 +247,5 @@ def _get_cell_string_value(self, cell) -> str:
# https://github.com/pandas-dev/pandas/pull/36175#discussion_r484639704
value.append(self._get_cell_string_value(fragment))
else:
value.append(str(fragment))
value.append(str(fragment).strip("\n"))
return "".join(value)
Binary file added pandas/tests/io/data/excel/test_newlines.ods
View file
Open in desktop
Binary file not shown.
12 changes: 12 additions & 0 deletions pandas/tests/io/excel/test_odf.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,3 +36,15 @@ def test_read_writer_table():
result = pd.read_excel("writertable.odt", sheet_name="Table1", index_col=0)

tm.assert_frame_equal(result, expected)


def test_read_newlines_between_xml_elements_table():
# GH#45598
expected = pd.DataFrame(
[[1.0, 4.0, 7], [np.nan, np.nan, 8], [3.0, 6.0, 9]],
columns=["Column 1", "Column 2", "Column 3"],
)

result = pd.read_excel("test_newlines.ods")

tm.assert_frame_equal(result, expected)