TST: Use pytest or decorator instead of checking ImportError #45152
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
mroeschke
commented
Jan 1, 2022
mroeschke
commented
- tests added / passed
- Ensure all linting tests pass, see here for how to run them
MarcoGorelli
reviewed
Jan 2, 2022
| assert_stat_op_api("kurt", float_frame, float_string_frame) | ||
| except ImportError: | ||
| pass | ||
| @pytest.mark.filterwarnings("ignore:Dropping of nuisance:FutureWarning") |
There was a problem hiding this comment.
I'm getting
pandas/tests/frame/test_reductions.py::TestDataFrameAnalytics::test_stat_op_api_skew_kurt
/pandas/tests/frame/test_reductions.py:160: FutureWarning: Dropping of nuisance columns in DataFrame reductions (with 'numeric_only=None') is deprecated; in a future version this will raise TypeError. Select only valid columns before calling the reduction.
getattr(float_string_frame, opname)(axis=0)
without it. Copying it from the original larger test, guessing it's based on the fixture data and assert_stat_op_api
There was a problem hiding this comment.
Ah, I hadn't noticed it was part of the original test, thanks for explaining
MarcoGorelli
approved these changes
Jan 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.