-
-
Notifications
You must be signed in to change notification settings - Fork 18.6k
CI: Add mambaforge to ci builds #44967
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Nice! Any sense of how much faster the environment building is? |
The conda incubator takes around 3 minutes I think. With conda it takes around 4 in a best case scenario. Unfortunately we have a lot of builds where this takes more than 15, while mamba should stay at around 3 for them. It will keep our build times consistent. Unfortunately we have 2 failing pipelines which do seem relevant, will check what this is about |
This is not finished yet. I will have to figure out how to fix the installation issues before adding this somewhere else. |
FYI, on my machine (macOS) those tests run fine when using the script. |
This is not a test issue per se. Mamba resolves the dependencies differently, which results in different versions. The 3.9 build installs arrow 2.0.1 instead of 6.0.0, causing the tests to fail. I think I found a solution for this, but have to look a bit further |
What I meant to say is that for me Mamba seems to resolve correctly/in a way that doesn't break the tests. |
With the 3.9 dependency file? Could you post the output of conda info? |
Yeah, would want to avoid the pin, but we'll see. Will finish this tomorrow after the setuptools pin is merged |
This is ready for review. We have a few builds where creating the environment regularly takes more than one hour. Mamba does speed up the process a bit in general, but more important: it does not take forever in some instances. The 3.9 envs are solved a bit weird. Hence I added the pyarrow pin, which avoids this |
.github/workflows/ci.yml
Outdated
@@ -41,6 +41,8 @@ jobs: | |||
|
|||
- uses: conda-incubator/setup-miniconda@v2 | |||
with: | |||
mamba-version: "*" | |||
channels: conda-forge,defaults |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we avoid adding defaults as a channel here and elsewhere, if possible? Having multiple channels tends to slow things down a bit.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep, works.
do we still have pyarrow 1.* testing? |
Yep, for example in Database / Linux_py38_IO (ci/deps/actions-38-db-min.yaml) |
thanks @phofl |
No description provided.