Skip to content

CI: Add mambaforge to ci builds #44967

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
Dec 23, 2021
Merged

Conversation

phofl
Copy link
Member

@phofl phofl commented Dec 19, 2021

No description provided.

@phofl phofl marked this pull request as draft December 19, 2021 00:44
@phofl phofl changed the title Add mambaforge to github actions ci Add mambaforge to ci builds Dec 19, 2021
@mroeschke
Copy link
Member

Nice! Any sense of how much faster the environment building is?

@phofl
Copy link
Member Author

phofl commented Dec 19, 2021

The conda incubator takes around 3 minutes I think. With conda it takes around 4 in a best case scenario. Unfortunately we have a lot of builds where this takes more than 15, while mamba should stay at around 3 for them. It will keep our build times consistent.

Unfortunately we have 2 failing pipelines which do seem relevant, will check what this is about

@jonashaag
Copy link
Contributor

@phofl
Copy link
Member Author

phofl commented Dec 19, 2021

This is not finished yet. I will have to figure out how to fix the installation issues before adding this somewhere else.

@jonashaag
Copy link
Contributor

FYI, on my machine (macOS) those tests run fine when using the script.

@phofl
Copy link
Member Author

phofl commented Dec 19, 2021

This is not a test issue per se. Mamba resolves the dependencies differently, which results in different versions. The 3.9 build installs arrow 2.0.1 instead of 6.0.0, causing the tests to fail. I think I found a solution for this, but have to look a bit further

@jonashaag
Copy link
Contributor

What I meant to say is that for me Mamba seems to resolve correctly/in a way that doesn't break the tests.

@phofl
Copy link
Member Author

phofl commented Dec 19, 2021

With the 3.9 dependency file? Could you post the output of conda info?

@jreback jreback added the CI Continuous Integration label Dec 19, 2021
@jonashaag
Copy link
Contributor

@phofl see #44979, seems to work ok

@phofl
Copy link
Member Author

phofl commented Dec 20, 2021

Yeah, would want to avoid the pin, but we'll see. Will finish this tomorrow after the setuptools pin is merged

@phofl phofl marked this pull request as ready for review December 21, 2021 23:17
@phofl
Copy link
Member Author

phofl commented Dec 21, 2021

This is ready for review.

We have a few builds where creating the environment regularly takes more than one hour. Mamba does speed up the process a bit in general, but more important: it does not take forever in some instances.

The 3.9 envs are solved a bit weird. Hence I added the pyarrow pin, which avoids this

@phofl phofl changed the title Add mambaforge to ci builds CI: Add mambaforge to ci builds Dec 21, 2021
@@ -41,6 +41,8 @@ jobs:

- uses: conda-incubator/setup-miniconda@v2
with:
mamba-version: "*"
channels: conda-forge,defaults
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we avoid adding defaults as a channel here and elsewhere, if possible? Having multiple channels tends to slow things down a bit.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, works.

@jreback jreback added this to the 1.4 milestone Dec 22, 2021
@jreback
Copy link
Contributor

jreback commented Dec 22, 2021

do we still have pyarrow 1.* testing?

@phofl
Copy link
Member Author

phofl commented Dec 22, 2021

Yep, for example in Database / Linux_py38_IO (ci/deps/actions-38-db-min.yaml)

@jreback jreback merged commit d2abc92 into pandas-dev:master Dec 23, 2021
@jreback
Copy link
Contributor

jreback commented Dec 23, 2021

thanks @phofl

@phofl phofl deleted the github_actions_mamba branch December 23, 2021 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI Continuous Integration
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants