Skip to content

TYP: Upgrade to mypy 0.920 #44936

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Dec 22, 2021
Merged

TYP: Upgrade to mypy 0.920 #44936

merged 4 commits into from
Dec 22, 2021

Conversation

phofl
Copy link
Member

@phofl phofl commented Dec 17, 2021

  • Ensure all linting tests pass, see here for how to run them

new mypy was released

@phofl phofl added the Typing type annotations, mypy/pyright type checking label Dec 17, 2021
@phofl phofl marked this pull request as draft December 17, 2021 09:02
@phofl
Copy link
Member Author

phofl commented Dec 17, 2021

Converting to draft till mypy is on conda-forge

@phofl phofl marked this pull request as ready for review December 18, 2021 00:05
@twoertwein
Copy link
Member

Converting to draft till mypy is on conda-forge

seems to be available: https://anaconda.org/conda-forge/mypy

@phofl
Copy link
Member Author

phofl commented Dec 18, 2021

yep, ci is green, was failing before

@lithomas1 lithomas1 modified the milestones: 2.0, 1.4 Dec 19, 2021
@jreback
Copy link
Contributor

jreback commented Dec 22, 2021

one more rebase if you don't mind (as just merged your typing PR)

@phofl
Copy link
Member Author

phofl commented Dec 22, 2021

rebased and greenish @jreback

@jreback jreback merged commit 0e58307 into pandas-dev:master Dec 22, 2021
@jreback
Copy link
Contributor

jreback commented Dec 22, 2021

thanks @phofl

@phofl phofl deleted the new_mypy branch December 22, 2021 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Typing type annotations, mypy/pyright type checking
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants