BUG: IntervalArray.__cmp__(pd.NA) #44830
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jreback
requested changes
Dec 9, 2021
| elif isinstance(obj, pd.core.arrays.BooleanArray): | ||
| return obj | ||
| elif isinstance(dtype, IntervalDtype): | ||
| return pd.core.arrays.IntervalArray(obj) |
There was a problem hiding this comment.
can you use is_interval_dtype to be consistent
|
Perf! Have another branch that will move them all to the faster version
…On Thu, Dec 9, 2021 at 3:52 PM Jeff Reback ***@***.***> wrote:
***@***.**** requested changes on this pull request.
------------------------------
In pandas/_testing/__init__.py
<#44830 (comment)>:
> @@ -282,6 +283,10 @@ def to_array(obj):
return DatetimeArray._from_sequence(obj)
elif is_timedelta64_dtype(dtype):
return TimedeltaArray._from_sequence(obj)
+ elif isinstance(obj, pd.core.arrays.BooleanArray):
+ return obj
+ elif isinstance(dtype, IntervalDtype):
+ return pd.core.arrays.IntervalArray(obj)
can you use is_interval_dtype to be consistent
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#44830 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AB5UM6HGLKEGVOJT24XOAJTUQE6LRANCNFSM5JXPZ4BA>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
|
jreback
approved these changes
Dec 11, 2021
|
if you can add a whatsnew in followon |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Could repurpose #31882 to be about the more general case and not just IntervalArray?
DataFrame cases fail in a way that would be avoided with 2D EAs.