Skip to content

TST: group by - apply Key Error #44806

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 10, 2021
Merged

TST: group by - apply Key Error #44806

merged 2 commits into from
Dec 10, 2021
+22 −0

Conversation

brunoacpcosta
Copy link
Contributor

@brunoacpcosta brunoacpcosta commented Dec 7, 2021 •
edited
Loading

@brunoacpcosta brunoacpcosta changed the title TST: Group By - Apply Key Error TST: group by - apply Key Error Dec 8, 2021
phofl
phofl requested changes Dec 10, 2021
View reviewed changes
Copy link
Member

@phofl phofl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of comments

@pep8speaks
Copy link

pep8speaks commented Dec 10, 2021 •
edited
Loading

Hello @brunoacpcosta! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2021-12-10 18:40:54 UTC

phofl
phofl reviewed Dec 10, 2021
View reviewed changes
phofl
phofl approved these changes Dec 10, 2021
View reviewed changes
Copy link
Member

@phofl phofl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@brunoacpcosta
Copy link
Contributor Author

brunoacpcosta commented Dec 10, 2021 •
edited
Loading

Thanks for the help!

@mroeschke mroeschke added this to the 1.4 milestone Dec 10, 2021
@mroeschke mroeschke added Groupby Testing pandas testing functions or related to the test suite labels Dec 10, 2021
@mroeschke mroeschke merged commit f34a65b into pandas-dev:master Dec 10, 2021
@mroeschke
Copy link
Member

Thanks @brunoacpcosta

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mroeschke mroeschke mroeschke approved these changes

@phofl phofl phofl approved these changes

Assignees
No one assigned
Labels
Groupby Testing pandas testing functions or related to the test suite
Projects
None yet
Milestone
1.4
Development

Successfully merging this pull request may close these issues.

BUG: groupby apply KeyError, hash instability?
4 participants
@brunoacpcosta @pep8speaks @mroeschke @phofl