BUG: Raise TypeError for scalar indexer in take #44763
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phofl
requested changes
Dec 5, 2021
| @@ -70,6 +70,13 @@ def test_take(self, index): | |||
| with pytest.raises(AttributeError, match=msg): | |||
| index.freq | |||
|
|
|||
| def test_take_indexer_type(self): | |||
| integer_index = Int64Index([0, 1, 2, 3]) | |||
There was a problem hiding this comment.
I think this index constructor is deprecated, please use Index(
phofl
approved these changes
Dec 10, 2021
|
Could you rebase master? We had a few ci failures |
Use pandas is_scalar, remove deprecated constructor, add GH issue number to test
mroeschke
approved these changes
Dec 10, 2021
|
Thanks @gfkang |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.