PERF: slow tests #44727
Merged
PERF: slow tests #44727
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jreback
reviewed
Dec 2, 2021
pandas/core/dtypes/missing.py
Outdated
| @@ -644,3 +646,8 @@ def is_valid_na_for_dtype(obj, dtype: DtypeObj) -> bool: | |||
|
|
|||
| # fallback, default to allowing NaN, None, NA, NaT | |||
| return not isinstance(obj, (np.datetime64, np.timedelta64, Decimal)) | |||
|
|
|||
|
|
|||
| def _is_string_dtype(dtype: np.dtype) -> bool: | |||
There was a problem hiding this comment.
hmm can you simply move this to dtypes.core.common next to the other one
There was a problem hiding this comment.
Sure. most recent commit also added an improvement for random_text
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Biggest difference is in test_get_loc_tuple_monotonic_above_size_cutoff going from 12.92 seconds t 4.72, all in improving DatetimeLikeArray.astype.