Skip to content

COMPAT: Fix FutureWarning in tests with pyarrow 6.0.0 #44662

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 29, 2021

Conversation

lithomas1
Copy link
Member

@lithomas1 lithomas1 commented Nov 29, 2021

FutureWarning: Parquet format '2.0' pseudo version is deprecated, use '2.4' or '2.6' for fine-grained feature selection

This was the warning.

Judging from the comment and https://github.com/apache/parquet-format/blob/master/CHANGES.md, the correct version should be 2.6.0 since that's when https://issues.apache.org/jira/browse/PARQUET-1387 was added.

This was showing up as a warning on fastparquet's pandas-dev CI.

  • closes #xxxx
  • tests added / passed
  • Ensure all linting tests pass, see here for how to run them
  • whatsnew entry

Not an expert on arrow stuff, though, so deferring to @jorisvandenbossche's review.

Judging from the comment and https://github.com/apache/parquet-format/blob/master/CHANGES.md, the correct version should be 2.6.0 since that's when https://issues.apache.org/jira/browse/PARQUET-1387 was added.

This was showing up as a warning on fastparquet's pandas-dev CI.
@lithomas1 lithomas1 added Arrow pyarrow functionality Compat pandas objects compatability with Numpy or Python functions Testing pandas testing functions or related to the test suite labels Nov 29, 2021
@lithomas1 lithomas1 added this to the 1.4 milestone Nov 29, 2021
@lithomas1 lithomas1 marked this pull request as ready for review November 29, 2021 03:00
Copy link
Member

@jorisvandenbossche jorisvandenbossche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, this is perfect, thanks!

@jorisvandenbossche jorisvandenbossche changed the title COMPAT: Fix FutureWarning with pyarrow 6.0.0 COMPAT: Fix FutureWarning in tests with pyarrow 6.0.0 Nov 29, 2021
@jorisvandenbossche jorisvandenbossche merged commit b6d9c89 into pandas-dev:master Nov 29, 2021
@lithomas1 lithomas1 deleted the fix-pyarrow-warning branch November 29, 2021 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Arrow pyarrow functionality Compat pandas objects compatability with Numpy or Python functions Testing pandas testing functions or related to the test suite
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants