BUG/OFMT: fix repring of python3 bytes objects #4456
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
| @@ -1613,7 +1613,8 @@ def _is_sequence(x): | |||
| try: | |||
| iter(x) | |||
| len(x) # it has a length | |||
| return not isinstance(x, compat.string_types) and True | |||
| return not isinstance(x, compat.string_types + | |||
| (compat.binary_type,)) and True | |||
There was a problem hiding this comment.
@jreback is this True here for a reason? It will have no effect on the return value of _is_sequence...
|
@jreback ok 2 merge? |
| return not isinstance(x, compat.string_types) and True | ||
| except Exception: | ||
| len(x) # it has a length | ||
| return not isinstance(x, compat.string_types + (compat.binary_type,)) |
There was a problem hiding this comment.
I would define something like compat.string_and_binary_types
There was a problem hiding this comment.
Btw - that only matters for python3 - bytes is str in py2
On Aug 3, 2013 1:47 PM, "Phillip Cloud" notifications@github.com wrote:
In pandas/core/common.py:
@@ -1612,9 +1612,9 @@ def is_list_like(arg):
def _is_sequence(x):
try:
iter(x)
len(x) # it has a lengthreturn not isinstance(x, compat.string_types) and True- except Exception:
len(x) # it has a lengthreturn not isinstance(x, compat.string_types + (compat.binary_type,))ok
—
Reply to this email directly or view it on GitHubhttps://github.com//pull/4456/files#r5567493
.
There was a problem hiding this comment.
yes but that's issue here...
|
think this is good 2 go now |
|
ok |
cpcloud
added a commit
that referenced
this pull request
Aug 3, 2013
BUG/OFMT: fix repring of python3 bytes objects
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #4455.