BUG: Index with object dtype and negative loc for insert adding none and replacing existing value #44545
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…and replacing existing value
| # GH#44509 | ||
| idx = Index(["1", "2", "3"]) | ||
| result = idx.insert(loc, val) | ||
| expected = Index(["1", "2", val, "3"]) |
There was a problem hiding this comment.
can you check that type(expected[2]) is type(val); numpy often messes that up with dt64/td64
There was a problem hiding this comment.
numpy/numpy#12550 i dont know exactly what conditions it shows up in, but i get nervous whenever np.datetime64 or np.timedelta64 objects get near an object-dtype ndarray
|
thanks @phofl |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This behaves like np.insert, so changed the docstring. Making this compatible with list.insert would be a breaking change
Nevertheless the else block in the base implementation had a bug, so fixed that one too