Skip to content

CLN: remove is_null_datetimelike #44540

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 20, 2021

Conversation

jbrockmendel
Copy link
Member

  • closes #xxxx
  • tests added / passed
  • Ensure all linting tests pass, see here for how to run them
  • whatsnew entry

No longer needed following #44507

Copy link
Contributor

@jreback jreback left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can u perf check things, though wouldn't anticpate any slowdowns

@jreback jreback added Clean Missing-data np.nan, pd.NaT, pd.NA, dropna, isnull, interpolate labels Nov 20, 2021
@jbrockmendel
Copy link
Member Author

can u perf check things, though wouldn't anticpate any slowdowns

In [3]: from pandas._libs.missing import checknull
In [4]: %timeit checknull("foo")
74.2 ns ± 0.39 ns per loop (mean ± std. dev. of 7 runs, 10000000 loops each)  # <- master
73.4 ns ± 0.323 ns per loop (mean ± std. dev. of 7 runs, 10000000 loops each)  # <- PR

@jreback jreback added this to the 1.4 milestone Nov 20, 2021
@jreback jreback merged commit 7d6d609 into pandas-dev:master Nov 20, 2021
@jbrockmendel jbrockmendel deleted the ref-is_null_datetimelike branch November 20, 2021 21:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Clean Missing-data np.nan, pd.NaT, pd.NA, dropna, isnull, interpolate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants