REF: combine isnaobj+isnaobj_old #44505
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
jbrockmendel
commented
Nov 18, 2021
jbrockmendel
commented
- closes #xxxx
- tests added / passed
- Ensure all linting tests pass, see here for how to run them
- whatsnew entry
mroeschke
reviewed
Nov 18, 2021
| or util.is_float_object(val) and (val == INF or val == NEGINF) | ||
| ) | ||
| return result.view(np.bool_) | ||
| return isnaobj(arr, inf_as_na=True) |
There was a problem hiding this comment.
Is it possible to just call isnaobj(arr, inf_as_na=True) where isnaobj_old(arr) is called (same for isnaobj2d)?
There was a problem hiding this comment.
it is, im planning to do that in a separate pass
mroeschke
added
Missing-data
mroeschke
approved these changes
Nov 18, 2021
jreback
approved these changes
Nov 20, 2021
| return val != val | ||
| if val != val: | ||
| return True | ||
| if inf_as_na: |
There was a problem hiding this comment.
elif but doesn't matter much
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.