Skip to content

BUG: NumericArray.__pos__ should make a copy #44492

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 17, 2021
Merged

BUG: NumericArray.__pos__ should make a copy #44492

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pandas/core/arrays/numeric.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -168,7 +168,7 @@ def __neg__(self):
return type(self)(-self._data, self._mask.copy())

def __pos__(self):
return self
return self.copy()

def __abs__(self):
return type(self)(abs(self._data), self._mask.copy())
Expand Down
2 changes: 1 addition & 1 deletion pandas/core/arrays/timedeltas.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -800,7 +800,7 @@ def __neg__(self) -> TimedeltaArray:
return type(self)(-self._ndarray)

def __pos__(self) -> TimedeltaArray:
return type(self)(self._ndarray, freq=self.freq)
return type(self)(self._ndarray.copy(), freq=self.freq)

def __abs__(self) -> TimedeltaArray:
# Note: freq is not preserved
Expand Down
2 changes: 2 additions & 0 deletions pandas/tests/arrays/floating/test_arithmetic.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -200,4 +200,6 @@ def test_unary_float_operators(float_ea_dtype, source, neg_target, abs_target):

tm.assert_extension_array_equal(neg_result, neg_target)
tm.assert_extension_array_equal(pos_result, arr)
assert not np.shares_memory(pos_result._data, arr._data)
assert not np.shares_memory(pos_result._mask, arr._mask)
tm.assert_extension_array_equal(abs_result, abs_target)
2 changes: 2 additions & 0 deletions pandas/tests/arrays/integer/test_arithmetic.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -300,4 +300,6 @@ def test_unary_int_operators(any_signed_int_ea_dtype, source, neg_target, abs_ta

tm.assert_extension_array_equal(neg_result, neg_target)
tm.assert_extension_array_equal(pos_result, arr)
assert not np.shares_memory(pos_result._data, arr._data)
assert not np.shares_memory(pos_result._mask, arr._mask)
tm.assert_extension_array_equal(abs_result, abs_target)
2 changes: 2 additions & 0 deletions pandas/tests/arrays/test_timedeltas.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,9 +99,11 @@ def test_pos(self):

result = +arr
tm.assert_timedelta_array_equal(result, arr)
assert not np.shares_memory(result._ndarray, arr._ndarray)

result2 = np.positive(arr)
tm.assert_timedelta_array_equal(result2, arr)
assert not np.shares_memory(result2._ndarray, arr._ndarray)

def test_neg(self):
vals = np.array([-3600 * 10 ** 9, "NaT", 7200 * 10 ** 9], dtype="m8[ns]")
Expand Down