CI/TST Removed Timestamp.now() from tests. #44341

[Mikhaylov-yv]

Removed Timestamp.now() from tests. #44341

Replaced Timestamp.now () with pd.Timestamp (2021, 1, 1, 12)

[pep8speaks]

Hello @Mikhaylov-yv! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2021-11-14 22:54:51 UTC

[jreback]

@Mikhaylov-yv does this cover all the uses in the tests (aside from specifically testing .now()?)

can you merge master.

also wouldn't object to a rule against using Timestamp.now() in testing (exempting the very few cases that we need it); this could be a followup or in this PR

[jreback]

cc @mroeschke

[mroeschke]

LGTM pending green. Looks like there's a few more occurrences that can be addressed in another PR.

[Mikhaylov-yv]

Hello @jreback @mroeschke .

In these tests, Timestamp (2021, 1, 1, 12) is suitable as a replacement for Timestamp.now (). Did I understand correctly?
In order not to duplicate the code, can I make a Timestamp (2021, 1, 1, 12) as a fixture?

Using this example, I wanted to make sure that I was doing it right.

If everything is OK. I will make corrections to all tests where there is a Timestamp.now (). Of course other than those checking the Timestamp.now ().

[mroeschke]

In order not to duplicate the code, can I make a Timestamp (2021, 1, 1, 12) as a fixture?

Good idea. A new fixed_now_ts fixture would be helpful. Maybe also add minutes, seconds and microseconds to the fixture Timestamp just in case it was significant.

Also not mentioned in the original issue, but this also applies to utcnow where the original method isn't being tested.

[jreback]

thanks @Mikhaylov-yv happy to have you followup with a fixture for the 'now' tests.

[Mikhaylov-yv]

@jreback Thanks for the support. I keep working on the problem.