Skip to content

CLN: de-duplicate Ellipsis-handling #44238

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 30, 2021
Merged

CLN: de-duplicate Ellipsis-handling #44238

merged 2 commits into from
Oct 30, 2021

Conversation

jbrockmendel
Copy link
Member

  • closes #xxxx
  • tests added / passed
  • Ensure all linting tests pass, see here for how to run them
  • whatsnew entry

@jreback
Copy link
Contributor

jreback commented Oct 30, 2021

pandas/core/arrays/sparse/array.py:886: error: Non-overlapping identity check (left operand type: "Union[Union[Union[int, integer[Any]], Union[slice, List[int], ndarray[Any, Any]]], Tuple[Union[int, ellipsis], ...]]", right operand type: "ellipsis") [comparison-overlap]

otherwise lgtm.

@jreback jreback added this to the 1.4 milestone Oct 30, 2021
@jreback jreback added Clean Indexing Related to indexing on series/frames, not to indexes themselves labels Oct 30, 2021
alimcmaster1
alimcmaster1 approved these changes Oct 30, 2021
View reviewed changes
Copy link
Member

@alimcmaster1 alimcmaster1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice - LGTM!

@alimcmaster1 alimcmaster1 merged commit 19f06d9 into pandas-dev:master Oct 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alimcmaster1 alimcmaster1 alimcmaster1 approved these changes

Assignees
No one assigned
Labels
Clean Indexing Related to indexing on series/frames, not to indexes themselves
Projects
None yet
Milestone
1.4
Development

Successfully merging this pull request may close these issues.
3 participants
@jbrockmendel @jreback @alimcmaster1