Skip to content

CI: Pin pre-commit python version #44134

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 21, 2021
Merged

CI: Pin pre-commit python version #44134

merged 1 commit into from
Oct 21, 2021

Conversation

alimcmaster1
Copy link
Member

@alimcmaster1 alimcmaster1 commented Oct 21, 2021

Looks like GH actions/setup-python seems to have randomly jumped from python 3.9.7 to python 3.10.0

Working:
https://github.com/pandas-dev/pandas/runs/3947277622?check_suite_focus=true#step:3:5

Failing:
https://github.com/pandas-dev/pandas/runs/3960125988?check_suite_focus=true#step:3:5

We can pin to a specific python version as per:
https://github.com/actions/setup-python#usage

Needs backport to 1.3.x also failing there to: https://github.com/pandas-dev/pandas/runs/3959049188?check_suite_focus=true

@alimcmaster1 alimcmaster1 added the CI Continuous Integration label Oct 21, 2021
@alimcmaster1 alimcmaster1 added this to the 1.4 milestone Oct 21, 2021
@alimcmaster1 alimcmaster1 changed the title CI: Update pre-commit.yml CI: Pin pre-commit python version Oct 21, 2021
Copy link
Member

@jbrockmendel jbrockmendel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM pending green

@jreback jreback modified the milestones: 1.4, 1.3.5 Oct 21, 2021
@jreback
Copy link
Contributor

jreback commented Oct 21, 2021

thanks @alimcmaster1 merge on green

@alimcmaster1
Copy link
Member Author

thanks @alimcmaster1 merge on green

Thanks will do and will backport

@alimcmaster1 alimcmaster1 merged commit 9b2bb73 into master Oct 21, 2021
meeseeksmachine pushed a commit to meeseeksmachine/pandas that referenced this pull request Oct 21, 2021
@alimcmaster1 alimcmaster1 deleted the alimcmaster1-patch-1 branch October 21, 2021 17:47
alimcmaster1 added a commit that referenced this pull request Oct 21, 2021
Co-authored-by: Ali McMaster <alimcmaster1@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI Continuous Integration
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CI: flake-rst updated?
3 participants