testing broadcast on multiindex #44094
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
gabrieldi95
commented
Oct 19, 2021
gabrieldi95
commented
- closes BUG: pd.DataFrame.add() does not broadcast across levels, when level is None #34388
- tests added / passed
- Ensure all linting tests pass, see here for how to run them
debnathshoham
added
the
Testing
jreback
requested changes
Oct 21, 2021
| def test_broadcast_multiindex(): | ||
| # GH34388 | ||
| df1 = DataFrame({"A": [0, 1, 2], "B": [1, 2, 3]}) | ||
| df1.columns.set_names("L1", inplace=True) |
There was a problem hiding this comment.
don't use inplace in tests, unless its actually testing inplace.
| df2 = DataFrame({("A", "C"): [0, 0, 0], ("A", "D"): [0, 0, 0]}) | ||
| df2.columns.set_names(["L1", "L2"], inplace=True) | ||
|
|
||
| result = df1.add(df2) |
There was a problem hiding this comment.
parameterize this over level=0 and level=None
|
can you merge master and update to comments |
|
Yes, I was working on other stuff, will work on it now! |
jreback
reviewed
Nov 17, 2021
|
|
||
|
|
||
| @pytest.mark.parametrize("level", [0, None]) | ||
| def test_broadcast_multiindex(level): |
There was a problem hiding this comment.
@jbrockmendel test in a good location?
There was a problem hiding this comment.
id put it in the TestFrameFlexArithmetic class in this file
jreback
added
MultiIndex
Numeric Operations
|
@gabrieldi95 can you merge once again and ping on green |
jreback
approved these changes
Nov 29, 2021
|
thanks @gabrieldi95 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.