-
-
Notifications
You must be signed in to change notification settings - Fork 18.6k
DOC: Added DataFrame in Parameters & Return description in the docstring #44007
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Hello @abatomunkuev! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found: There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻 Comment last updated at 2021-10-17 02:10:15 UTC |
pandas/core/tools/datetimes.py
Outdated
The object to convert to a datetime. | ||
The object to convert to a datetime. If the DataFrame is provided,the method | ||
expects minimally the following columns: "year", "month", "day" | ||
in the DataFrame. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: in the DataFrame
is redundant from If the DataFrame
in the first line.
pandas/core/tools/datetimes.py
Outdated
@@ -692,7 +692,9 @@ def to_datetime( | |||
Parameters | |||
---------- | |||
arg : int, float, str, datetime, list, tuple, 1-d array, Series, DataFrame/dict-like | |||
The object to convert to a datetime. | |||
The object to convert to a datetime. If the DataFrame is provided,the method |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: provided,the
-> provided, the
Thanks @abatomunkuev |
Thanks @abatomunkuev ! |
Hello! I have added the following information to the source code (docstring of to_datetime method):
I have created Docker Image & Python Environment, then tested my docstring update by using
validate_docstrings.py
script.Before testing my update, I have run the script on master branch. The script found 2 errors on master branch:
Then, I switched to my feature branch and run the
validate_docstrings.py
script.Output of the script
There are still some errors from master branch.