Skip to content

REF: use _unary_method for SparseArray.__abs__ #43846

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 1, 2021

Conversation

jbrockmendel
Copy link
Member

Upcoming PR will expand maybe_dispatch_ufunc_to_dunder_op to include unary methods, so this is needed to prevent circularity.

Copy link
Member

@mzeitlin11 mzeitlin11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably a perf improvement too since no longer going through ufunc machinery

@mzeitlin11 mzeitlin11 added Numeric Operations Arithmetic, Comparison, and Logical operations Refactor Internal refactoring of code Sparse Sparse Data Type labels Oct 1, 2021
@mzeitlin11 mzeitlin11 added this to the 1.4 milestone Oct 1, 2021
@jreback jreback merged commit ef31301 into pandas-dev:master Oct 1, 2021
@jbrockmendel jbrockmendel deleted the ref-sparse-ufunc branch October 2, 2021 01:45
gasparitiago pushed a commit to gasparitiago/pandas that referenced this pull request Oct 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Numeric Operations Arithmetic, Comparison, and Logical operations Refactor Internal refactoring of code Sparse Sparse Data Type
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants