Skip to content

REF: unwrap PandasArray earlier #43728

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Sep 25, 2021
Merged

REF: unwrap PandasArray earlier #43728

merged 3 commits into from
Sep 25, 2021

Conversation

jbrockmendel
Copy link
Member

  • closes #xxxx
  • tests added / passed
  • Ensure all linting tests pass, see here for how to run them
  • whatsnew entry

@jreback
Copy link
Contributor

jreback commented Sep 25, 2021

is this user facing in any way? any perf change?

@jreback jreback added ExtensionArray Extending pandas with custom dtypes or arrays. Refactor Internal refactoring of code labels Sep 25, 2021
@jreback jreback added this to the 1.4 milestone Sep 25, 2021
@jbrockmendel
Copy link
Member Author

is this user facing in any way?

no

any perf change?

we'll take a hit from the isinstance check in sanitize_array, but a pretty good improvement from removing two maybe_coerce_values (though i forget which was the motivating asv for this)

@jreback jreback merged commit 764045d into pandas-dev:master Sep 25, 2021
@jbrockmendel jbrockmendel deleted the bug-extract_pandas_dtype branch September 25, 2021 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
ExtensionArray Extending pandas with custom dtypes or arrays. Refactor Internal refactoring of code
Projects
None yet
Milestone
1.4
Development

Successfully merging this pull request may close these issues.
2 participants
@jbrockmendel @jreback