Skip to content

PERF: Groupby.quantile #43725

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 27, 2021
Merged

Conversation

jbrockmendel
Copy link
Member

from asv_bench.benchmarks.groupby import *
self2 = GroupByMethods()
self2.setup('uint', 'quantile', 'direct', 1)

%timeit self2.time_dtype_as_group('uint', 'quantile', 'direct', 1)
1.03 ms ± 46.9 µs per loop (mean ± std. dev. of 7 runs, 1000 loops each)  # <- master
328 µs ± 17.2 µs per loop (mean ± std. dev. of 7 runs, 1000 loops each)  # <- PR

Copy link
Member

@mzeitlin11 mzeitlin11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mzeitlin11 mzeitlin11 added this to the 1.4 milestone Sep 27, 2021
@mzeitlin11 mzeitlin11 added Groupby Numeric Operations Arithmetic, Comparison, and Logical operations Performance Memory or execution speed performance labels Sep 27, 2021
@jreback jreback merged commit cdb725f into pandas-dev:master Sep 27, 2021
@jbrockmendel jbrockmendel deleted the perf-gb-quantile branch September 27, 2021 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Groupby Numeric Operations Arithmetic, Comparison, and Logical operations Performance Memory or execution speed performance
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants